Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remerge app.py #429

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Remerge app.py #429

merged 2 commits into from
Aug 21, 2019

Conversation

mottosso
Copy link
Contributor

#388 mistakenly merged the wrong app.py for the new loader. See #426 (comment)

@davidlatwe At first glance, this appears to be working, however the style doesn't appear to work, and I'm not sure why? :S

Before

image

After

image

This appears to be the only file missing
@mottosso
Copy link
Contributor Author

These are both running Loader from outside of Maya, e.g.

python -m avalon --loader

@davidlatwe
Copy link
Collaborator

I just checked-out your branch. and..
No matter I launcher Loader inside or outside of Maya, all failed to reproduce it 0.0

@davidlatwe
Copy link
Collaborator

The only difference (compare to the commit before 388) I spotted was this line, it's from #393 here, the last missing piece.

- assets = AssetWidget()
+ assets = AssetWidget(silo_creatable=False)

@mottosso
Copy link
Contributor Author

Ok, I can confirm this only happens with PySide2-5.13, and does not happen with..

  • PySide
  • PySide2-5.12
  • PyQt4
  • PyQt5-5.12

Very strange, but probably nothing we need to worry about.

@mottosso mottosso merged commit 8da6c68 into getavalon:master Aug 21, 2019
@mottosso
Copy link
Contributor Author

The only difference (compare to the commit before 388) I spotted was this line, it's from #393 here, the last missing piece.

Sorry, missed this. Pushed this directly to master just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants